feat: Add task handler api c++ #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
ddiakiteaneo
requested review from
ddubuc,
lemaitre-aneo,
ngruelaneo,
dbrasseur-aneo and
rbenabda
dbrasseur-aneo
requested changes
Jul 5, 2023
packages/cpp/ArmoniK.Api.Worker/source/Worker/ArmoniKWorker.cpp
Outdated
Show resolved
Hide resolved
packages/cpp/ArmoniK.Api.Worker/source/Worker/ArmoniKWorker.cpp
Outdated
Show resolved
Hide resolved
| if (init_request.payload().data_complete()) { | ||
| std::string temp = init_request.payload().data(); | ||
| payload.resize(temp.length()); | ||
| for (size_t i = 0; i < temp.length(); i++) { | ||
| payload[i] = static_cast<std::byte>(temp[i]); | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this is correct, you cannot have data_complete AND data
Comment on lines
85
to
88
| chuncks.push_back(datachunck.data()); | ||
| } | ||
|
|
||
| size_t size = chuncks.size(); | ||
|
|
||
| auto payload_data = new std::byte[size]; | ||
| int address = 0; | ||
| for (auto iter = chuncks.begin(); iter != chuncks.end(); iter++) { | ||
| std::string temp_str = *iter; | ||
|
|
||
| for (size_t i = 0; i < temp_str.length(); i++) { | ||
| payload_data[i + address] = static_cast<std::byte>(temp_str[i]); | ||
| } | ||
| address += temp_str.length(); | ||
| } | ||
|
|
||
| payload.resize(size); | ||
| std::copy_n(payload_data, size, std::back_inserter(payload)); | ||
| } |
There was a problem hiding this comment.
1 : what's the point of payload_data ? You already have payload
2 : Both payload_data and payload are local, they cannot be accessed !
ddiakiteaneo
force-pushed
the
ddi/task-handler
branch
from
4cf07c7 to
b5a23ed
Compare
ddiakiteaneo
force-pushed
the
ddi/task-handler
branch
from
b5a23ed to
f2d6986
Compare
dbrasseur-aneo
approved these changes
Jul 12, 2023
Comment on lines
+67
to
+69
| static auto to_request_stream(const std::vector<armonik::api::grpc::v1::TaskRequest> &task_requests, | ||
| armonik::api::grpc::v1::TaskOptions task_options, size_t chunk_max_size) | ||
| -> std::vector<std::future<std::vector<armonik::api::grpc::v1::agent::CreateTaskRequest>>>; |
There was a problem hiding this comment.
Suggested change
| static auto to_request_stream(const std::vector<armonik::api::grpc::v1::TaskRequest> &task_requests, | |
| armonik::api::grpc::v1::TaskOptions task_options, size_t chunk_max_size) | |
| -> std::vector<std::future<std::vector<armonik::api::grpc::v1::agent::CreateTaskRequest>>>; | |
| static std::vector<std::future<std::vector<armonik::api::grpc::v1::agent::CreateTaskRequest>>> to_request_stream(const std::vector<armonik::api::grpc::v1::TaskRequest> &task_requests, | |
| armonik::api::grpc::v1::TaskOptions task_options, size_t chunk_max_size); | |
Comment on lines
+237
to
+241
| for (auto task_request = task_requests.begin(); task_request != task_requests.end(); ++task_request) { | ||
| const bool is_last = task_request == task_requests.end() - 1 ? true : false; | ||
|
|
||
| async_chunk_payload_tasks.push_back(task_chunk_stream(*task_request, is_last, chunk_max_size)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (auto task_request = task_requests.begin(); task_request != task_requests.end(); ++task_request) { | |
| const bool is_last = task_request == task_requests.end() - 1 ? true : false; | |
| async_chunk_payload_tasks.push_back(task_chunk_stream(*task_request, is_last, chunk_max_size)); | |
| } | |
| for (auto&& task_request : task_requests) { | |
| const bool is_last = task_request == task_requests.end() - 1 ? true : false; | |
| async_chunk_payload_tasks.push_back(task_chunk_stream(*task_request, is_last, chunk_max_size)); | |
| } | |
There was a problem hiding this comment.
Not sure between auto& and auto&&
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.