Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add task options to sort in session #307

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

esoubiran-aneo
Copy link
Contributor

@esoubiran-aneo esoubiran-aneo commented Jun 26, 2023

We want to be able to sort on every field so we need to add task options to sessions.

Using tasks_common.TaskOptionField does not work.

@esoubiran-aneo esoubiran-aneo added the enhancement New feature or request label Jun 26, 2023
@esoubiran-aneo esoubiran-aneo self-assigned this Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
515 466 90% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 58da3e7 by action🐍

Copy link
Contributor Author

@esoubiran-aneo esoubiran-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update this using messages. like in #343

@aneojgurhem
Copy link
Contributor

Let's do it in another PR

@aneojgurhem aneojgurhem merged commit 2016d6e into main Jul 10, 2023
@aneojgurhem aneojgurhem deleted the feat/add-task-options-to-session branch July 10, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants