Don't send DISCARD after ExecAbortError in pipeline #1301
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Don't send
DISCARD
afterExecAbortError
when executing aMULTI
/EXEC
transaction in thePipeline
class.The
EXECABORT
error type was added in Redis 2.6.5 and is returned from anEXEC
command to indicate that the transaction was aborted due to an invalid command. It is not necessary to callDISCARD
after this error, and doing so causes a "DISCARD without MULTI" error.Fixes #1300
Pull Request check-list
$ tox
pass with this change (including linting)?