Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline incorrectly calls DISCARD after EXEC in case of EXECABORT error #1300

Closed
nickgaya opened this issue Mar 5, 2020 · 1 comment
Closed

Comments

@nickgaya
Copy link
Contributor

nickgaya commented Mar 5, 2020

Version:
Redis-py 3.4.1
Redis 5.0.7

Platform:
Python 3.8.2
Mac OS 10.13.6

Description:
Executing an explicit transaction containing an invalid command results in a response error, masking the original parsing error.

Example:

from redis import Redis
redis = Redis(...)

with redis.pipeline() as pipe:
    pipe.multi()
    pipe.execute_command('INCR', 'a', 'b', 'c')
    pipe.execute()

Expected:

redis.exceptions.ResponseError: Command # 1 (INCR a b c) of pipeline caused error: wrong number of arguments for 'incr' command

Actual:

redis.exceptions.ResponseError: DISCARD without MULTI
@andymccurdy
Copy link
Contributor

Merged in 07fec7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants