Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds an optional option
custom_name
to specify a custom name instead of the stream name in the resulting filename.E.g: Stream name is
entities
and timestamp is20210218T000000
custom_name=""
anddo_timestamp_file=true
Results in:
/tmp/entities-20210218T000000.jsonl
custom_name="entity"
anddo_timestamp_file=true
Results in:
/tmp/entity-20210218T000000.jsonl
custom_name="entity"
anddo_timestamp_file=false
Results in:
/tmp/entity.jsonl
custom_name=""
anddo_timestamp_file=false
Results in:
/tmp/entities.jsonl
Manual QA steps
destination_path
,custom_name
and `do_timestamp_file tested and worked as expectedRisks
Rollback steps