-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add customer and request endpoints for service desk api #391
feat: add customer and request endpoints for service desk api #391
Conversation
3a5e9d2
to
a2daf69
Compare
} | ||
|
||
// Create wraps CreateWithContext using the background context. | ||
func (c *CustomerService) Create(email, displayName string) (*Customer, *Response, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we expose this method without a context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a CustomerService.CreateWithContext
which is the context version of the method. I followed this pattern from other service endpoints in the package.
a2daf69
to
71f2d08
Compare
Thank you for the review! I believe that I've addressed your comments, please let me know if there's any other changes needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update as requested by @james-cast since the service desk id is supposed to be a string.
71f2d08
to
a00fdd5
Compare
I have updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Information that is useful here:
Example:
Tests exist for all new endpoints, which is probably the best source of sample code.
Checklist