Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board type list option incombatible with REST API #213

Closed
xaniasd opened this issue May 10, 2019 · 1 comment · Fixed by #214
Closed

board type list option incombatible with REST API #213

xaniasd opened this issue May 10, 2019 · 1 comment · Fixed by #214

Comments

@xaniasd
Copy link
Contributor

xaniasd commented May 10, 2019

according to the docs BoardListOptions.BoardType should be mapped to type, now it's boardType.

Because of this, filtering boards based on type does not work.

Shall I create a PR?
@ghostsquad
Copy link
Contributor

PR's always welcome! When creating your PR the minimum expectations are:

xaniasd added a commit to xaniasd/go-jira that referenced this issue May 12, 2019
@xaniasd
Fix board request parameter
2c411bd 
The BoardListOption field BoardType was incorrectly mapped to boardType
instead of type. This commit fixes it. A generic test helper
function (testRequestParams) is added in order to improve the
effectiveness of the unit test.

Fixes andygrunwald#213
@xaniasd xaniasd mentioned this issue May 12, 2019
Merged
andygrunwald pushed a commit that referenced this issue May 12, 2019
@xaniasd @andygrunwald
Fix board request parameter
7e0dd0e 
The BoardListOption field BoardType was incorrectly mapped to boardType
instead of type. This commit fixes it. A generic test helper
function (testRequestParams) is added in order to improve the
effectiveness of the unit test.

Fixes #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix board request parameter xaniasd/go-jira
2 participants
@ghostsquad @xaniasd