Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove final modifiers #225

Merged
merged 1 commit into from
Nov 30, 2021
Merged

remove final modifiers #225

merged 1 commit into from
Nov 30, 2021

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Nov 30, 2021

prepare Scala 3

Welcome to Scala 3.1.0 (11.0.13, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.

scala> final object Foo
-- Warning:
1 |final object Foo
  |^^^^^
  |Modifier final is redundant for this definition
// defined object Foo

@xuwei-k
remove final modifiers
e5d0e70 
prepare Scala 3

```
Welcome to Scala 3.1.0 (11.0.13, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.

scala> final object Foo
-- Warning:
1 |final object Foo
  |^^^^^
  |Modifier final is redundant for this definition
// defined object Foo
```
andyglow
andyglow approved these changes Nov 30, 2021
View reviewed changes
Copy link
Owner

@andyglow andyglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you @xuwei-k

@andyglow andyglow merged commit e01fc0f into andyglow:master Nov 30, 2021
@xuwei-k xuwei-k deleted the remove-object-final-modifier branch November 30, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyglow andyglow andyglow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @andyglow