NativeMarkText doesn't build on armv7 [#3] #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Problem As reported in #3, the NativeMarkText+UIKit doesn't build for device. Investigation showed that was because the enclosing projects were trying to build armv7 and SwiftUI doesn't include an armv7 binary. Therefore, it appeared like SwiftUI wasn't defined and compiling the file failed with undefined symbols. # Solution As a workaround, only build the NativeMarkText+UIKit.swift file for armv64 and x86_64. It is a bit fragile in that if new architectures appear, they'll have to be manually added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As reported in #3, the NativeMarkText+UIKit doesn't build for device. Investigation showed that was because the enclosing projects were trying to build armv7 and SwiftUI doesn't include an armv7 binary. Therefore, it appeared like SwiftUI wasn't defined and compiling the file failed with undefined symbols.
Solution
As a workaround, only build the NativeMarkText+UIKit.swift file for armv64 and x86_64. It is a bit fragile in that if new architectures appear, they'll have to be manually added.