Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring all-day events are not showed today #89

Closed
jmcortesmartinez opened this issue Feb 5, 2022 · 26 comments
Closed

Recurring all-day events are not showed today #89

jmcortesmartinez opened this issue Feb 5, 2022 · 26 comments

Comments

@jmcortesmartinez
Copy link

If you have a recurring all-day event you can see it all the others days except today.
It does not affect whether the event is new or old.

I have detected this issue in the last few days. Before it worked properly.

Thank you for your work!

@ls5454ss
Copy link

ls5454ss commented Mar 8, 2022

I am having this same issue. I have to enable one day old events to see them, and they are showing as "old/past due"...even though the date is today's date. This is frustrating, as I'm stuck seeing ACTUAL old events as well, which I do not want to see.

Is this project still being worked? Is this something that will be resolved? Thank you for your time

  • Steve

@yvolk
Copy link
Member

yvolk commented Mar 9, 2022

Hi @ls5454ss Please "Share events and settings for debugging" as described in #71 in order for me to understand, why today's all day event is not shown.

Yesterday I created today's all day event, and today I still do see it (old events are disabled).
BTW is the problem with recurring events only?

@jmcortesmartinez
Copy link
Author

As I said in my first message is with recurring events only.

For example:

If I have an annual recurring event for today (a birthday for example) I could see it yesterday but not today.

Here you have my "events and settings for debugging":

{
"deviceInfo": {
"versionCode": 31,
"versionRelease": "12",
"versionCodename": "REL",
"buildManufacturer": "Google",
"buildBrand": "google",
"buildModel": "Pixel 3a"
},
"applicationInfo": {
"versionName": "4.4.0",
"versionCode": 691
},
"settings": {
"widgetId": 3,
"widgetHeaderDateFormat": "defaultWeekday:",
"widgetInstanceName": "Todo Agenda 3",
"activeSources": [
{
"providerType": 1,
"id": 2,
"title": "Cumpleaños",
"summary": "[email protected]",
"color": -509406,
"isAvailable": true
}
],
"eventRange": 30,
"eventsEnded": "NONE",
"fillAllDay": true,
"hideBasedOnKeywords": "",
"widgetHeaderBackgroundColor": 0,
"pastEventsBackgroundColor": -1082623956,
"todaysEventsBackgroundColor": 0,
"backgroundColor": 0,
"textColorSource": "shading",
"headerTheme": "BLACK",
"widgetHeaderTextColor": -1694498817,
"dayHeaderThemePast": "DARK",
"dayHeaderTextColorPast": -3355444,
"entryThemePast": "BLACK",
"eventTextColorPast": -1,
"dayHeaderTheme": "BLACK",
"dayHeaderTextColorToday": -8947849,
"entryTheme": "BLACK",
"eventTextColorToday": -16777216,
"dayHeaderThemeFuture": "BLACK",
"dayHeaderTextColorFuture": -3355444,
"entryThemeFuture": "BLACK",
"eventTextColorFuture": -1,
"showDaysWithoutEvents": false,
"showDayHeaders": true,
"dayHeaderDateFormat": "defaultWeekday:",
"horizontalLineBelowDayHeader": true,
"showPastEventsUnderOneHeader": false,
"showPastEventsWithDefaultColor": false,
"showEventIcon": true,
"entryDateFormat": "hidden:",
"showEndTime": true,
"showLocation": true,
"dateFormat": "auto",
"lockedTimeZoneId": "",
"snapshotMode": "live_data",
"refreshPeriodMinutes": 10,
"eventEntryLayout": "DEFAULT",
"multiline_title": false,
"multiline_details": false,
"showOnlyClosestInstanceOfRecurringEvent": false,
"hideDuplicates": false,
"allDayEventsPlacement": "top_day",
"taskScheduling": "date_due",
"taskWithoutDates": "end_of_list",
"filterMode": "normal",
"indicateAlerts": true,
"indicateRecurring": false,
"compactLayout": false,
"widgetHeaderLayout": "HIDDEN",
"textSizeScale": "1.0",
"dayHeaderAlignment": "LEFT"
},
"resultsVersion": 3,
"results": [
{
"providerType": 1,
"executedAt": 1646835074016,
"timeZoneId": "Europe/Madrid",
"millisOffsetUtcToLocal": 3600000,
"standardMillisOffsetUtcToLocal": 3600000,
"uri": "content://com.android.calendar/instances/when/1646835074016/1649423474016",
"projection": [
"calendar_id",
"event_id",
"title",
"begin",
"end",
"allDay",
"eventLocation",
"hasAlarm",
"rrule",
"displayColor",
"calendar_color"
],
"selection": "selfAttendeeStatus!=2 AND (calendar_id = 2 )",
"selectionArgs": [],
"sortOrder": "startDay ASC, allDay DESC, begin ASC ",
"rows": [
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=12;BYMONTH=3"
},
"event_id": {
"type": 1,
"value": 194
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1647043200000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "María (1986)"
},
"begin": {
"type": 1,
"value": 1647043200000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=TU"
},
"event_id": {
"type": 1,
"value": 794
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1647043200000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Erick (Agustín Y Diana)"
},
"begin": {
"type": 1,
"value": 1647043200000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=21;BYMONTH=3"
},
"event_id": {
"type": 1,
"value": 199
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1647820800000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Laia (1973)"
},
"begin": {
"type": 1,
"value": 1647820800000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=21;BYMONTH=3"
},
"event_id": {
"type": 1,
"value": 541
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1647820800000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Carla (Dani Badia y Laura) (2011)"
},
"begin": {
"type": 1,
"value": 1647820800000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=26;BYMONTH=3"
},
"event_id": {
"type": 1,
"value": 181
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1648252800000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Candela (sobrina de Rafa Baena) (2014) "
},
"begin": {
"type": 1,
"value": 1648252800000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=3;BYMONTH=4"
},
"event_id": {
"type": 1,
"value": 185
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1648944000000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Rosa Lucero"
},
"begin": {
"type": 1,
"value": 1648944000000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=4;BYMONTH=4"
},
"event_id": {
"type": 1,
"value": 182
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1649030400000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Ambrosio (1925)"
},
"begin": {
"type": 1,
"value": 1649030400000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=4;BYMONTH=4"
},
"event_id": {
"type": 1,
"value": 183
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1649030400000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Tía Mercedes"
},
"begin": {
"type": 1,
"value": 1649030400000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
},
{
"allDay": {
"type": 1,
"value": 1
},
"rrule": {
"type": 3,
"value": "FREQ=YEARLY;WKST=MO;BYMONTHDAY=6;BYMONTH=4"
},
"event_id": {
"type": 1,
"value": 184
},
"calendar_id": {
"type": 1,
"value": 2
},
"eventLocation": {
"type": 3,
"value": ""
},
"end": {
"type": 1,
"value": 1649203200000
},
"displayColor": {
"type": 1,
"value": -509406
},
"title": {
"type": 3,
"value": "Rafa Arroyo (ICTA) (1964)"
},
"begin": {
"type": 1,
"value": 1649203200000
},
"hasAlarm": {
"type": 1,
"value": 0
},
"calendar_color": {
"type": 1,
"value": -509406
}
}
]
}
]
}

@yvolk
Copy link
Member

yvolk commented Mar 9, 2022

Thank you @jmcortesmartinez
I loaded your events and I do see them all (9 events) today, on March 9.
When I change date on the device to March 12, I still see 2 events on than date (Erick... and Maria...).
When I change date to March 13, the events on March 12 disappear (as expected).

So it looks like the problem is not in displaying and filtering of the list of events, but in their querying from Android Calendar provider. This worked for years, so strange that something changed...

In order to make sure that our widget queries today's events, I can actually query for one more day of events than necessary, and filter out unneeded in the widget... will do this and let you check!

@jmcortesmartinez
Copy link
Author

Maybe this captures will help you, despite being in spanish:

1.- This is a capture of my Google Calendar widget showing birthdays in March

Screenshot_20220309-180804

2.- And this is a capture of my TodoAgenda widget

Screenshot_20220309-180820

As you can see today is the birthday of Luis but I can't see it in the TodoAgenda widget.

Thank you very much for you time,
Jose

@yvolk
Copy link
Member

yvolk commented Mar 9, 2022

Yes, @jmcortesmartinez , I see this on my device (I corrected my previous post, wrong names were there for March 12...)

@yvolk
Copy link
Member

yvolk commented Mar 9, 2022

@jmcortesmartinez In order to fix the problem please try this:
In the widget's settings go to "Event Filters"
then scroll down to "Filters troubleshooting"
and set it to "Debug filtering".

Today's recurring events should appear.

?!

@yvolk
Copy link
Member

yvolk commented Mar 9, 2022

@jmcortesmartinez @ls5454ss I made a fix and posted v.4.5.0 here: #3
Please check.

@jmcortesmartinez
Copy link
Author

Sorry, the v.4.5.0 closes instantly when opened.

I have installed it from Files with the apk.

I have a Pixel 3a with Android 12
Last security update: Feb-5 202

@ls5454ss
Copy link

ls5454ss commented Mar 9, 2022

@yvolk I'm not sure if I'm doing anything wrong here, but, the new version doesn't seem to be working at all. I had to uninstall 4.4 to get 4.5 to install (said there was a conflict when trying to upgrade). I was able to install the new version, but when trying to customize the widget, it crashed. Now when I try to click the "blank" widget, the app immediately crashes. Unsure if it's something on my end or not. Uninstalling/reinstalling does not seem to work, nor does restarting the phone.

Reinstalling 4.4 seems to work. I'm on a Pixel 6 Pro if that helps. Android 12. Thanks for your assistance

@yvolk
Copy link
Member

yvolk commented Mar 10, 2022

@ls5454ss Thank you for checking.
I see that the problem with v.4.5.0 was due to specific new requirements for Android 12 ( https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability )
I fixed the problem, checked it on my Android 12 device - it works there, and published v.4.5.1.
Please check it. #3

@jmcortesmartinez
Copy link
Author

It works!

Thank you very much for your time and your work. Impressive.

@ls5454ss
Copy link

@yvolk it seems to work so far - thank you! I'll let you know via this thread if I see any more issues in regards to these events not showing. Thank you so much for your time!

:: edit ::
I do show one issue (I think it's an issue...). When I click any of the events, they do not load in Google Calendar - they do nothing. Unsure if this is related to whatever changes you may have just made

The second random issue I see, which MAY have been seen in a previous version, is that some of my EXTREMELY old recurring events (some could even be 10 years old...) are shown as a "darker gray". Screenshot attached comparing a very old version of the widget to this latest version. Latest version is on the top. I honestly don't mind just re-creating those very old recurring events if needed...but just thought I would let you know.

Again - thank you for your time and talents :)

Todo Screenshot

@yvolk
Copy link
Member

yvolk commented Mar 10, 2022

I do show one issue (I think it's an issue...). When I click any of the events, they do not load in Google Calendar - they do nothing. Unsure if this is related to whatever changes you may have just made

Yes, this is a new bug. Will fix it now.

@ls5454ss
Copy link

I do show one issue (I think it's an issue...). When I click any of the events, they do not load in Google Calendar - they do nothing. Unsure if this is related to whatever changes you may have just made

Yes, this is a new bug. Will fix it now.

Thank you for your time, @yvolk - much appreciated!

@yvolk
Copy link
Member

yvolk commented Mar 10, 2022

The second random issue I see, which MAY have been seen in a previous version, is that some of my EXTREMELY old recurring events (some could even be 10 years old...) are shown as a "darker gray". Screenshot attached comparing a very old version of the widget to this latest version. Latest version is on the top. I honestly don't mind just re-creating those very old recurring events if needed...but just thought I would let you know.

This issue / feature may be related to the recent change "Implement strikethrough and partial transparency for event status" see #82. In a case that new feature works not as intended, please create a separate issue for it.

@yvolk
Copy link
Member

yvolk commented Mar 10, 2022

@ls5454ss I fixed the bug with not working clicks on events in Android 12: here the "PendingIntent" needed to be "MUTABLE", please check v.4.5.2 here: #3

@ls5454ss
Copy link

@ls5454ss I fixed the bug with not working clicks on events in Android 12: here the "PendingIntent" needed to be "MUTABLE", please check v.4.5.2 here: #3

That seems to have done it - thank you once again for your time! :)

  • Steve

@yvolk
Copy link
Member

yvolk commented Mar 10, 2022

@ls5454ss @jmcortesmartinez Thank you for your feedback!

@ls5454ss
Copy link

Hi @yvolk - sorry to be the bearer of bad news, but something is still not right. The day is not over yet ~7:00pm, and my event is now not showing in the widget. Any idea what could be wrong, with the widget thinking the event is already done, even though the day isn't over? Two screenshots shown - one of the actual event, one of the widget VS a Google Calendar widget.

Thanks again for your time
1
2
!

@yvolk
Copy link
Member

yvolk commented Mar 11, 2022

@ls5454ss
Q1. Do I understand correctly that before my changes similar events disappeared at midnight on the day of the all day event, and now they disappear 19 hours later than before?!
What I actually did: I moved earliest selection date-time one full day back, so I would expect that all events will disappear one full day later.

Q2. Please in "Event filters" allow "Show past events: Ended today" - do you see the Today's All day event? Is it shown as Today in the widget?

Q3. Please in "Event filters" allow "Show past events: Ended yesterday" - do you see the Today's All day event? Is it shown as Today in the widget?

Q4. When you DO see that All day event (in some settings, enabling past events...), please in "Feedback and Backup" -> "Share events and settings for debugging" and send that JSON text to me, so I could look at that event.

Note: I'm starting to suspect that for that (new, recurring...) events our widget doesn't recognize the event as an All day event! It may think that the event starts and ends at 12 AM UTC !!! Please check.
Next day starts at UTC when it is about 7PM in your location?!

@ls5454ss
Copy link

Hi @yvolk

Q1: I am not sure. I've been using a VERY old version of this, considering when I tried the latest version (before we started talking) it didn't work either. I'd have to install version 4.4.0 and test to answer this question. If you'd like me to, I will, and compare between 4.4.0 and 4.5.2. I do recall, even on my very old version, that SOME all day recurring events would show initially, and remove before the end of the day. I say this, because I usually "pay my bills" at the end of the day, and missed a few because they weren't showing when I looked at the widget.

Note: Your "note" does make sense. I tried messing around in the settings last night, thinking the same thing - but didn't really see anything that would help, other than trying to mess with the time zone on my phone (which I didn't get to try).

Q2. I can try this later tonight, when my event goes away. I have one recurring event (all day) and I created a new one (all day, recurring) as well. Stay tuned.

Q3. Same as Q2 - stay tuned.

Q4. Sure thing - will do.

Thank you again for your time!

@ls5454ss
Copy link

ls5454ss commented Mar 12, 2022

Hello again, @yvolk

Q2 - "Event filters" allow "Show past events: Ended today" - this made the events show up.

Q4 - file attached, compressed - setting changed to showing past events, ended today. Couldn't attach a JSON

Thanks again for your time!

::edit:: re-uploaded
Todo-Agenda-29-Todo-Agenda-shareEvents-2022-03-11-19-58-02-646 3.json.zip

@yvolk
Copy link
Member

yvolk commented Mar 12, 2022

@ls5454ss Thank you for the info. After my investigations and attempts to reproduce the problem I think that the only problem is in the start date/time of the query, which I corrected (by one day) once.
Now I ended in 2 days correction and looks like this helps to show All day events.
Please check v.4.5.3 here #3

yvolk added a commit that referenced this issue Mar 12, 2022
@ls5454ss
Copy link

@yvolk - thank you again for your time. Will install now and provide feedback soon :)

@ls5454ss
Copy link

@yvolk I think whatever you changed seems to be working now. I didn't have any issues with the all day events, and they seemed to clear ~ midnight now.

I'll keep you posted if I see any more issues with this. Thank you again for your time, and have a great rest of the weekend!

@yvolk yvolk closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants