Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(travis): Adding node versions and develop branch #15

Merged
merged 2 commits into from
Jul 23, 2016
Merged

chore(travis): Adding node versions and develop branch #15

merged 2 commits into from
Jul 23, 2016

Conversation

andrscrrn
Copy link
Owner

We should be testing in the latest version of Node 4, 5 and 6. Also, the develop branch should be
integrated into the CI.

chore(travis): Adding node versions and develop branch
58a2679 
We should be testing in the latest version of Node 4, 5 and 6. Also, the develop branch should be
integrated into the CI.
@andrscrrn
Copy link
Owner Author

I think that the build is failing because of this:

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants eslint@^2.10.2 || 3.x
npm ERR! peerinvalid Peer [email protected] wants [email protected] - 3.x
npm ERR! peerinvalid Peer [email protected] wants eslint@^2.9.0

Any ideas @baldore?

@andrscrrn
Copy link
Owner Author

The problem seems to be eslint-config-airbnb

chore(package.json): Using previous version of ESLINT
6fef226 
Apparently this is affecting the Travis CI
@codecov-io
Copy link

codecov-io commented Jul 23, 2016 •
edited
Loading

Current coverage is 74.71% (diff: 100%)

No coverage report found for develop at cc17f70.

Powered by Codecov. Last update cc17f70...cd6fedc

@baldore
Copy link
Collaborator

baldore commented Jul 23, 2016

@andresdavid90 We're gonna have to downgrade eslint. I think it's related to this: airbnb/javascript#936

@andrscrrn
Copy link
Owner Author

andrscrrn commented Jul 23, 2016 •
edited
Loading

@baldore I already did in the last commit. Please somebody check and merge this. 🙃

@baldore
Copy link
Collaborator

baldore commented Jul 23, 2016

hehehehe I found the same solution. Testing in local with Node 4.4.7. I'll close it if everything runs ok.

@baldore baldore closed this Jul 23, 2016
@baldore baldore reopened this Jul 23, 2016
@baldore baldore merged commit 6b8ffcf into develop Jul 23, 2016
@andrscrrn andrscrrn deleted the TRAVIS_UPDATES branch July 23, 2016 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrscrrn @codecov-io @baldore