-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Extractor/Mp4 Atom Parsing code reusable by external custom mp4 … #1607
Conversation
Thanks for sending this. I'm going to submit some of this myself directly internally:
Once these changes are submitted I'll let you know and you can rebase this change so it only has the |
The changes have been submitted: The final change renamed
I suggest we rename I don't mind if you do that in this PR, or we can do it directly as an internal change. |
@icbaker Rebased to capture your commits and renamed to BoxParsers. Thank you! edit: There was one commit from the pull that didn't pass CLA checks for some reason. Hence, I've rebased my commits to the top and force pushed for simplicity |
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
…extractors