-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a callback on Loader to signal when a Load starts #1580
Conversation
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/Loader.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/Loader.java
Outdated
Show resolved
Hide resolved
@icbaker I have incorporated the comments |
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
Apologies @icbaker , I accidentally updated my main branch and had newer commits rebased on top. Hope this doesn't complicate the internal review |
No worries, i've force pushed my own changes back. |
btw I think people often send PRs from not the main branch of their forks, possibly for this reason, but as an aside: using the main branch in your fork also slightly upsets GitHub's command line tool because we have to run:
Because the regular command will try to update our
So for future PRs, it might be useful to create a new well-named branch in your fork for each one. |
Thanks. I didn't realize that the branch of the fork continuously updates the PR. I had thought it took a snapshot or merely cherry-picked the commits. Also good info on the |
This includes variables that captures the error and error count if it is starting a retry