Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An exception might be thrown inside MediaControllerImplBase.onPlayerInfoChanged() #51

Closed
h6ah4i opened this issue Mar 6, 2022 · 0 comments
Closed

An exception might be thrown inside MediaControllerImplBase.onPlayerInfoChanged() #51

h6ah4i opened this issue Mar 6, 2022 · 0 comments
Assignees
@marcbaechinger
Labels
bug

Comments

@h6ah4i
Copy link
Contributor

h6ah4i commented Mar 6, 2022 •
edited
Loading

Hi. I found the following crash report on Crashlytics. An exception thrown inside of the MediaControllerImplBase.onPlayerInfoChanged().

(Click here to display the full stacktrace) 
Fatal Exception: java.lang.IndexOutOfBoundsException: index (*) must be less than size (*)

Example 1

Fatal Exception: java.lang.IndexOutOfBoundsException: index (4) must be less than size (4)
       at com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1355)
       at com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1337)
       at com.google.common.collect.RegularImmutableList.get(RegularImmutableList.java:82)
       at androidx.media3.common.Timeline$RemotableTimeline.getWindow(Timeline.java:1530)
       at androidx.media3.common.Timeline.getWindow(Timeline.java:1118)
       at androidx.media3.session.PlayerInfo.getCurrentMediaItem(PlayerInfo.java:637)
       at androidx.media3.session.MediaControllerImplBase.onPlayerInfoChanged(MediaControllerImplBase.java:2383)
       at androidx.media3.session.MediaControllerStub.lambda$onPlayerInfoChanged$9(MediaControllerStub.java:180)
       at androidx.media3.session.MediaControllerStub.$r8$lambda$X59hShI5lo8-62FDwGBWO2tdQfo(MediaControllerStub.java)
       at androidx.media3.session.MediaControllerStub$$InternalSyntheticLambda$2$4a3a6820449623629e404f4bef3c0240e0815b9ab568a3a89e0663d3f4d5622f$0.run(MediaControllerStub.java:4)
       at androidx.media3.session.MediaControllerStub.lambda$dispatchControllerTaskOnHandler$12(MediaControllerStub.java:271)
       at androidx.media3.session.MediaControllerStub.$r8$lambda$YGpG-xpiKgSpdH847m1pEUdLemY(MediaControllerStub.java)
       at androidx.media3.session.MediaControllerStub$$InternalSyntheticLambda$3$c38f624292a1f1ed4af00152f20c76bcf37ccebfce0326ec339c89e37f90a1b6$0.run(MediaControllerStub.java:4)
       at androidx.media3.common.util.Util.postOrRun(Util.java:528)
       at androidx.media3.session.MediaControllerStub.dispatchControllerTaskOnHandler(MediaControllerStub.java:263)
       at androidx.media3.session.MediaControllerStub.onPlayerInfoChanged(MediaControllerStub.java:178)
       at androidx.media3.session.MediaSessionStub$Controller2Cb.onPlayerInfoChanged(MediaSessionStub.java:1734)
       at androidx.media3.session.MediaSessionImpl.dispatchOnPlayerInfoChanged(MediaSessionImpl.java:393)
       at androidx.media3.session.MediaSessionImpl.access$600(MediaSessionImpl.java:80)
       at androidx.media3.session.MediaSessionImpl$PlayerInfoChangedHandler.handleMessage(MediaSessionImpl.java:1186)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:246)
       at android.app.ActivityThread.main(ActivityThread.java:8653)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

Example 2

Fatal Exception: java.lang.IndexOutOfBoundsException: index (13) must be less than size (1)
       at com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1355)
       at com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1337)
       at com.google.common.collect.RegularImmutableList.get(RegularImmutableList.java:82)
       at androidx.media3.common.Timeline$RemotableTimeline.getWindow(Timeline.java:1530)
       at androidx.media3.common.Timeline.getWindow(Timeline.java:1118)
       at androidx.media3.session.PlayerInfo.getCurrentMediaItem(PlayerInfo.java:637)
       at androidx.media3.session.MediaControllerImplBase.onPlayerInfoChanged(MediaControllerImplBase.java:2383)
       at androidx.media3.session.MediaControllerStub.lambda$onPlayerInfoChanged$9(MediaControllerStub.java:180)
       at androidx.media3.session.MediaControllerStub.$r8$lambda$X59hShI5lo8-62FDwGBWO2tdQfo(MediaControllerStub.java)
       at androidx.media3.session.MediaControllerStub$$InternalSyntheticLambda$2$4a3a6820449623629e404f4bef3c0240e0815b9ab568a3a89e0663d3f4d5622f$0.run(MediaControllerStub.java:4)
       at androidx.media3.session.MediaControllerStub.lambda$dispatchControllerTaskOnHandler$12(MediaControllerStub.java:271)
       at androidx.media3.session.MediaControllerStub.$r8$lambda$YGpG-xpiKgSpdH847m1pEUdLemY(MediaControllerStub.java)
       at androidx.media3.session.MediaControllerStub$$InternalSyntheticLambda$3$c38f624292a1f1ed4af00152f20c76bcf37ccebfce0326ec339c89e37f90a1b6$0.run(MediaControllerStub.java:4)
       at androidx.media3.common.util.Util.postOrRun(Util.java:528)
       at androidx.media3.session.MediaControllerStub.dispatchControllerTaskOnHandler(MediaControllerStub.java:263)
       at androidx.media3.session.MediaControllerStub.onPlayerInfoChanged(MediaControllerStub.java:178)
       at androidx.media3.session.MediaSessionStub$Controller2Cb.onPlayerInfoChanged(MediaSessionStub.java:1734)
       at androidx.media3.session.MediaSessionImpl.dispatchOnPlayerInfoChanged(MediaSessionImpl.java:393)
       at androidx.media3.session.MediaSessionImpl.access$600(MediaSessionImpl.java:80)
       at androidx.media3.session.MediaSessionImpl$PlayerInfoChangedHandler.handleMessage(MediaSessionImpl.java:1186)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:193)
       at android.app.ActivityThread.main(ActivityThread.java:6819)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:497)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:912)

Library versions

  • androidx.media3: Built from source (Commit ID: f92ae23)

Affected devices

  • Samsung Galaxy S22 Ultra (Android 12)
  • Samsung Galaxy A71 (Android 11)
  • Infinix Smart 4 (Android 9)
  • and many more...

How to reproduce the issue?

Sorry, I have not succeeded in reproducing the issue yet. I'll post details if I can get any info.
@christosts christosts self-assigned this Mar 21, 2022
icbaker pushed a commit that referenced this issue May 9, 2022
@marcbaechinger @icbaker
Update session position info on timeline change
dee83cc 
This fixes an inconsistent state of the `PlayerInfo` when the index of the playing
media item is changed by a playlist modification. In this inconsistent state,
calling `Playerinfo.getCurrentMediaItem` can produce an
`ArrayIndexOutOfBoundException` (see stack trace in GH issue).

This change takes the following measurements:

- always update sessionPosition and timeline of the PlayerInfo together in
  `MediaSessionImpl.PlayerListener` where the PlayerInfo originates from
- add an assertion to avoid building a `PlayerInfo` instance in an inconsistent
  state
- reduce the window of opportunity for concurrent access to
  `mediaSessionImpl.playerInfo` when dispatching player info changes in
  `MediaSessionImpl`

Issue: #51
PiperOrigin-RevId: 444812661
@androidx androidx locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marcbaechinger marcbaechinger

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcbaechinger @h6ah4i @christosts