Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SsaDecoder does not support utf-16 encoded ass files #319

Closed
1 task done
viqbgrg opened this issue Apr 13, 2023 · 1 comment
Closed
1 task done

SsaDecoder does not support utf-16 encoded ass files #319

viqbgrg opened this issue Apr 13, 2023 · 1 comment
Assignees
@microkatz
Labels
enhancement

Comments

@viqbgrg
Copy link

viqbgrg commented Apr 13, 2023

Media3 Version

Media3 1.0.0

Devices that reproduce the issue

redmi k30pro running android 12

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

SsaDecoder uses utf8 by default, if you play subtitles in utf16 encoding format, there will be problems

Expected result

ass subtitles display normally

Actual result

SsaDecoder's parseHeader method equalsIgnoreCase cannot judge equality normally

Media

ass

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.
@viqbgrg viqbgrg changed the title SsaDecoder 不支持 utf-16 编码的ass文件 SsaDecoder does not support utf-16 encoded ass files Apr 13, 2023
marcbaechinger pushed a commit that referenced this issue May 3, 2023
@microkatz @marcbaechinger
Add UTF-16 encoded subtitle support to SsaDecoder
06ac2f7 
Issue: #319
PiperOrigin-RevId: 527891646
marcbaechinger pushed a commit to google/ExoPlayer that referenced this issue May 3, 2023
@microkatz @marcbaechinger
Add UTF-16 encoded subtitle support to SsaDecoder
a9c8f2f 
Issue: androidx/media#319
PiperOrigin-RevId: 527891646
@microkatz microkatz added enhancement and removed bug labels May 4, 2023
@microkatz
Copy link
Contributor

Hello @viqbgrg.

Thank you for logging your issue! We added support for utf-16 to the SsaDecoder. Here is a link, a9c8f2, to the commit to the main branch that added the feature. Hope this works! Please reopen if this does not fix your issue.

icbaker pushed a commit that referenced this issue May 17, 2023
@microkatz @icbaker
Add UTF-16 encoded subtitle support to SsaDecoder
841bdc6 
Issue: #319
PiperOrigin-RevId: 527891646
(cherry picked from commit 06ac2f7)
icbaker pushed a commit to google/ExoPlayer that referenced this issue May 17, 2023
@microkatz @icbaker
Add UTF-16 encoded subtitle support to SsaDecoder
b4bc82b 
Issue: androidx/media#319
PiperOrigin-RevId: 527891646
(cherry picked from commit a9c8f2f)
@androidx androidx locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@microkatz microkatz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viqbgrg @microkatz