-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds screenshot tests for snackbar #1343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
Combined test coverage report
Files
|
I'm afraid the screenshot tests can't cover the real snackbar screen. Because there's no system UI so that can't check this issue #1295. |
Yes, good reminder but that's a bug on the UI. When it's fixed, the author should add screenshot tests for it. |
JoseAlcerreca
force-pushed
the
ja/snackbar_stest
branch
from
March 27, 2024 09:32
727e802
to
ad31749
Compare
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
JoseAlcerreca
force-pushed
the
ja/snackbar_stest
branch
from
March 27, 2024 09:37
ad31749
to
f9601bb
Compare
Combined test coverage report
Files
|
alexvanyo
approved these changes
Apr 5, 2024
Adds modifier to NiaApp
Combined test coverage report
Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.