Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds screenshot tests for snackbar #1343

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Adds screenshot tests for snackbar #1343

merged 4 commits into from
Apr 11, 2024

Conversation

JoseAlcerreca
Copy link
Contributor

No description provided.

Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
Copy link

Combined test coverage report

Overall Project 40.15% -0.13% 🍏
Files changed 89.47% 🍏

Module Coverage
app 29.14% -0.64% 🍏
Files
Module File Coverage
app NiaApp.kt 86.56% -4.23% 🍏

@Jaehwa-Noh
Copy link
Contributor

I'm afraid the screenshot tests can't cover the real snackbar screen. Because there's no system UI so that can't check this issue #1295.

@JoseAlcerreca
Copy link
Contributor Author

Yes, good reminder but that's a bug on the UI. When it's fixed, the author should add screenshot tests for it.

Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
Copy link

Combined test coverage report

Overall Project 40.12% -0.13% 🍏
Files changed 89.47% 🍏

Module Coverage
app 29.14% -0.64% 🍏
Files
Module File Coverage
app NiaApp.kt 86.56% -4.23% 🍏

@JoseAlcerreca JoseAlcerreca marked this pull request as ready for review March 27, 2024 13:47
Adds modifier to NiaApp
Copy link

Combined test coverage report

Overall Project 40.16% -0.18% 🍏
Files changed 85.93% 🍏

Module Coverage
app 29.25% -0.93% 🍏
Files
Module File Coverage
app NiaApp.kt 85.08% -5.96% 🍏

@JoseAlcerreca JoseAlcerreca merged commit 16f45c0 into main Apr 11, 2024
4 checks passed
@JoseAlcerreca JoseAlcerreca deleted the ja/snackbar_stest branch April 11, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants