Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OkHttp lazy initialization #1190

Merged
merged 10 commits into from
Feb 8, 2024
Merged

OkHttp lazy initialization #1190

merged 10 commits into from
Feb 8, 2024

Commits on Feb 8, 2024

  1. Improve lazy loading for Coil + OkHttp 

    This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.

Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5f06121 View commit details
    Browse the repository at this point in the history

  2. Fix comment 

    Co-authored-by: Yuri Schimke <[email protected]>
    @mlykotom @yschimke
    mlykotom and yschimke committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8e3903e View commit details
    Browse the repository at this point in the history

  3. Launch loader directly without additional coroutine scope 

    Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7c33946 View commit details
    Browse the repository at this point in the history

  4. Don't use runBlocking if async init completed 

    Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e853748 View commit details
    Browse the repository at this point in the history

  5. Inline initialization 

    Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d1211f1 View commit details
    Browse the repository at this point in the history

  6. Add braces 

    Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f3e89ba View commit details
    Browse the repository at this point in the history

  7. Optimize OkHttp initialization for Retrofit 

    Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d110d92 View commit details
    Browse the repository at this point in the history

  8. Add comment for Retrofit async OkHttp 

    Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4cdc2ad View commit details
    Browse the repository at this point in the history

  9. Revert fast initialization of Coil 

    As discussed in coil-kt/coil#2097 the problem is caused by regitering system services, which will be fixed in 2.6.0

Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    58483b6 View commit details
    Browse the repository at this point in the history

  10. Use androidx.tracing everywhere 

    Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50
    @mlykotom
    mlykotom committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d9aaec0 View commit details
    Browse the repository at this point in the history