Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom RoomSchemaArgProvider in favor of the new Room Gradle plugin #1055

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

SimonMarquis
Copy link
Contributor

Since Room 2.6.0, a Gradle plugin was released to solve various existing issues in Room regarding having inputs and outputs of schemas via Gradle annotation processor options.
Changelog: https://developer.android.com/jetpack/androidx/releases/room#2.6.0-alpha02

See gradle/android-cache-fix-gradle-plugin#544 for reference.

@SimonMarquis SimonMarquis marked this pull request as ready for review November 21, 2023 20:07
@SimonMarquis
Copy link
Contributor Author

androidTest (30) hit the timeout

…e plugin

> Since Room 2.6.0, a Gradle plugin was released to solve various existing issues in Room regarding having inputs and outputs of schemas via Gradle annotation processor options.
> Changelog: https://developer.android.com/jetpack/androidx/releases/room#2.6.0-alpha02

See gradle/android-cache-fix-gradle-plugin#544 for reference.
@SimonMarquis
Copy link
Contributor Author

@dturner PR is ready to be reviewed.

@dturner dturner merged commit 9d2d5be into android:main Dec 21, 2023
4 checks passed
@SimonMarquis SimonMarquis deleted the room-gradle-plugin branch December 21, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants