Kotlinify codebase #1039
Merged
Kotlinify codebase #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonMarquis
force-pushed
the
kotlinify
branch
6 times, most recently
from
cc1d971 to
a81eaeb
Compare
- Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
SimonMarquis
force-pushed
the
kotlinify
branch
from
a81eaeb to
caa482b
Compare
dturner
reviewed
Dec 21, 2023
...n/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Dec 21, 2023
...lin/com/google/samples/apps/nowinandroid/feature/bookmarks/navigation/BookmarksNavigation.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Dec 21, 2023
...in/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Dec 21, 2023
...lin/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Dec 21, 2023
...in/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Dec 21, 2023
...lin/com/google/samples/apps/nowinandroid/feature/interests/navigation/InterestsNavigation.kt
Outdated
Show resolved
Hide resolved
dturner
requested changes
Dec 21, 2023
ktlint was merged in #1094 |
…nandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt Co-authored-by: Don Turner <[email protected]>
…droid/feature/foryou/navigation/ForYouNavigation.kt
…nandroid/feature/bookmarks/navigation/BookmarksNavigation.kt
…nandroid/feature/interests/navigation/InterestsNavigation.kt
…droid/feature/search/navigation/SearchNavigation.kt
|
@dturner PTAL, all your comments have been addressed 🤓 |
dturner
approved these changes
Dec 22, 2023
|
@SimonMarquis I can't see any changes relating to the resolved changes - did you forget to push a commit? |
dturner
requested changes
Dec 22, 2023
|
Oh apologies @SimonMarquis, for some reason I was reviewing outdated files which didn't have those commits. |
dturner
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)