-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fdprintf() available in stdio.h, but not libc.so #72
Comments
Looks like it was dropped in https://android-review.googlesource.com/#/c/194561/ It was made private in bionic because there is no such function. It looks like we have the POSIX extension There aren't any good options for fixing this right now, but this is the kind of thing that will be fixed when we clean up our headers and add the compatibility library (we'll be able to provide an implementation of For now, I think the best option is to use |
Headers are fixed, but I'm going to leave this open so I remember to make sure The part of this that can be fixed in r14 is fixed, so I'm re-triaging this. |
Compatibility library got pushed to r16 because O ate all of r15's time. |
Old versions of Android called these fdprintf and vfdprintf out of fears that the glibc names would collide with user debug printfs. Allow users to just use dprintf and vfdprintf on any version by renaming those calls to their legacy equivalents if needed. Test: built trivial NDK module targeting android-14 and using dprintf Test: make checkbuild Bug: android/ndk#72 Change-Id: I90de149278f931380418536abaef47c5cee5c195
The ordering of __attribute__ and __asm__ matters for GCC. Test: `#include <stdio.h>` with gcc Bug: android/ndk#72 Change-Id: I20bcd7cac2f96d220746e389f0ca467dc95c37c2
Fix ended up not needing to be added to the compatibility library. |
Old versions of Android called these fdprintf and vfdprintf out of fears that the glibc names would collide with user debug printfs. Allow users to just use dprintf and vfdprintf on any version by renaming those calls to their legacy equivalents if needed. Test: built trivial NDK module targeting android-14 and using dprintf Test: make checkbuild Bug: android/ndk#72 Change-Id: I90de149278f931380418536abaef47c5cee5c195
Old versions of Android called these fdprintf and vfdprintf out of fears that the glibc names would collide with user debug printfs. Allow users to just use dprintf and vfdprintf on any version by renaming those calls to their legacy equivalents if needed. Test: built trivial NDK module targeting android-14 and using dprintf Test: make checkbuild Bug: android/ndk#72 Change-Id: I90de149278f931380418536abaef47c5cee5c195
Same as this issue: https://code.google.com/p/android/issues/detail?id=11197
fdprintf() is missing from libc in the NDK again (since r11).
The text was updated successfully, but these errors were encountered: