Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targetSdkVersion should be 22 #56

Merged
merged 3 commits into from
Aug 15, 2015
Merged

targetSdkVersion should be 22 #56

merged 3 commits into from
Aug 15, 2015

Conversation

yaraki
Copy link
Contributor

@yaraki yaraki commented Aug 7, 2015

targetSdkVersion should be 22.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@proppy
Copy link
Contributor

proppy commented Aug 7, 2015

@yaraki can you change it on the other samples as well?

And possibly update https://github.com/googlesamples/android-ndk/tree/master/builder or https://github.com/googlesamples/android-ndk/blob/master/.travis.yml to enforce it?

@googlebot
Copy link

CLAs look good, thanks!

@proppy
Copy link
Contributor

proppy commented Aug 7, 2015

can you add something like this in .travis.yml for both compileSdkVersion and targetSdkVersion to ensure they remains the same when we update them in the future.

test $(echo $(grep -h compileSdkVersion */app/build.gradle  | uniq  | wc -l)) == "1"

@proppy
Copy link
Contributor

proppy commented Aug 13, 2015

rebase?

proppy added a commit that referenced this pull request Aug 15, 2015
targetSdkVersion should be 22
@proppy proppy merged commit 7c40802 into android:master Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants