Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoreTeapot: fix android lint warning #19

Merged
merged 2 commits into from
Jul 14, 2015
Merged

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Jun 30, 2015

/cc @hak @ggfan @claywilkinson

This remove lint warning from MoreTeaport sample.

  • bump minsdk from 11 to 19 since the code has some 19 only API calls.
  • update icon to default android studio mipmap
  • switch to RTL attributes for text placement
  • move text to resources

@claywilkinson
Copy link
Contributor

LGTM

@hak
Copy link
Contributor

hak commented Jul 13, 2015

For setSystemUiVisibility() (API-19), the code is checking API level and falling back to other pass.
So if this is the only reason to bump up the API level, we don't have to do that.

@proppy
Copy link
Contributor Author

proppy commented Jul 14, 2015

@hak PTAL

@hak
Copy link
Contributor

hak commented Jul 14, 2015

LGTM, too.

proppy added a commit that referenced this pull request Jul 14, 2015
MoreTeapot: fix android lint warning
@proppy proppy merged commit 703a72b into android:master Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants