Jetcaster UI updates #1498
Open
Jetcaster UI updates #1498
+305
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and removal of episode from queue
mlykotom
reviewed
Nov 6, 2024
| modifier = Modifier.fillMaxWidth() | ||
| ) | ||
| val sharedTransitionScope = LocalSharedTransitionScope.current | ||
| ?: throw IllegalStateException("No SharedElementScope found") |
There was a problem hiding this comment.
Would it be more appropriate to have this throw in the composition local definition (this is the practice we use)
It would also mean you don't have to have it nullable
Comment on lines
+362
to
+366
| val sharedTransitionScope = LocalSharedTransitionScope.current | ||
| ?: throw IllegalStateException("No SharedElementScope found") | ||
| val animatedVisibilityScope = LocalAnimatedVisibilityScope.current | ||
| ?: throw IllegalStateException("No SharedElementScope found") | ||
|
|
Comment on lines
+133
to
+141
| when (dismissState.currentValue) { | ||
| SwipeToDismissBoxValue.EndToStart -> { | ||
| removeFromQueue(episode) | ||
| } | ||
|
|
||
| SwipeToDismissBoxValue.StartToEnd -> { | ||
| } | ||
|
|
||
| SwipeToDismissBoxValue.Settled -> { |
There was a problem hiding this comment.
if we're not caring about the other states, should we just use
if (dismissState.currentValue == SwipeToDismissBoxValue.EndToStart) {
removeFromQueue(episode)
}
mlykotom
approved these changes
Nov 6, 2024
alexvanyo
reviewed
Nov 7, 2024
| ) { | ||
| val playerEpisode = uiState.episodePlayerState | ||
| val currentEpisode = playerEpisode.currentEpisode ?: return | ||
|
|
||
| val sharedTransitionScope = LocalSharedTransitionScope.current |
There was a problem hiding this comment.
Could this also be done in the non-regular PlayerContents for getting the same shared element transition for tabletop mode? Or maybe this could be done within the PlayerImage itself to avoid duplication?
mlykotom
added a commit
that referenced
this pull request
Nov 18, 2024
[Merge after #1498] - This PR merges the home UI state into one data class to be able to show loading state and content state at the same time. - It also fixes the progress to wait for the loading to finish. - Instead of circular progress, I switched to linear progress at the top of the content, which can indicate the work while showing content **After** https://github.com/user-attachments/assets/ec3e9220-addc-4b96-9b6a-477294b6cf85 **Before** https://github.com/user-attachments/assets/c795afc3-01f6-407b-b0b6-505da33652ec
|
As discussed previously, this PR needs to wait for the 1.8 stable and shared elements grid support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to Jetcaster: shared elements, swipetodismiss, lazy list animations and removal of episode from queue
Screen_recording_20241106_141006.mp4