Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved withContext() call up to surround all IO being performed. #1463

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,20 @@ class PodcastsFetcher @Inject constructor(
}

private suspend fun fetchPodcast(url: String): PodcastRssResponse {
val request = Request.Builder()
.url(url)
.cacheControl(cacheControl)
.build()
return withContext(ioDispatcher) {
val request = Request.Builder()
.url(url)
.cacheControl(cacheControl)
.build()

val response = okHttpClient.newCall(request).execute()
val response = okHttpClient.newCall(request).execute()

// If the network request wasn't successful, throw an exception
if (!response.isSuccessful) throw HttpException(response)
// If the network request wasn't successful, throw an exception
if (!response.isSuccessful) throw HttpException(response)

// Otherwise we can parse the response using a Rome SyndFeedInput, then map it
// to a Podcast instance. We run this on the IO dispatcher since the parser is reading
// from a stream.
return withContext(ioDispatcher) {
// Otherwise we can parse the response using a Rome SyndFeedInput, then map it
// to a Podcast instance. We run this on the IO dispatcher since the parser is reading
// from a stream.
response.body!!.use { body ->
syndFeedInput.build(body.charStream()).toPodcastResponse(url)
}
Expand Down