Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetsnack is laid out edge-to-edge in 2 & 3-button navigation mode #1263

Closed
wants to merge 1 commit into from

Conversation

manabu-nakamura
Copy link
Contributor

#1262

(before) Jetsnack is not laid out edge-to-edge in 2 & 3-button navigation mode (it is not drawn behind the system navigation bar in 2 & 3-button navigation mode).
Screenshot_20240215_103236
(after) Jetsnack is laid out edge-to-edge in 2 & 3-button navigation mode (it is drawn behind the system navigation bar in 2 & 3-button navigation mode).
Screenshot_20240215_103317


class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
enableEdgeToEdge()
super.onCreate(savedInstanceState)
ViewCompat.setOnApplyWindowInsetsListener(window.decorView) { _, insets -> insets }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets the inset and return it without doing anything. It seems to me that it doesn't do what the before/after screenshots do.
Is PR missing some commits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

stale bot commented Apr 17, 2024

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

@stale stale bot added the stale label Apr 17, 2024
@stale stale bot closed this Apr 25, 2024
@manabu-nakamura manabu-nakamura deleted the jetsnack branch September 3, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants