Fix background parallax #1230
Merged
Fix background parallax #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentrengrove
approved these changes
Nov 27, 2023
| @@ -45,20 +47,37 @@ fun Modifier.offsetGradientBackground( | |||
| colors: List<Color>, | |||
| width: Float, | |||
| offset: Float = 0f | |||
| ) = background( | |||
| ) = this then background( | |||
There was a problem hiding this comment.
I think the this then here is double adding the modifier because you have implicitly captured this already by not doing Modifier.background but just background which is actually this.background
We probably need another lint check for this as well!
There was a problem hiding this comment.
I'm actually not sure when you're supposed to use which. Happy to write the lint check!
There was a problem hiding this comment.
You basically just have to use this somewhere in your implementation. By just writing background you've done it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be a feature, but then when replacing with LazyRow, it was dropped.
Let's fix it + use the deferred modifier to properly read scroll state.