Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why using abs(dist*dist) for the one channel image in PBAS.cpp #218

Closed
batman47steam opened this issue Jan 31, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@batman47steam
Copy link

batman47steam commented Jan 31, 2023

dist = abs((((double)B_Col_Pts.at(0).at(index)[i] -

In PBAS.cpp for the three channel image, we compute dist like sqrt(a^2+b^2+c^2),but for the one channel image shouldn't we just compute distance like abs(a) dist = abs(((double)B_Col_Pts.at(0).at(index)[i] - ((double)*currentFeaturesC_Pt.at(0))) not dist = abs((((double)B_Col_Pts.at(0).at(index)[i] - ((double)*currentFeaturesC_Pt.at(0)))*((double)B_Col_Pts.at(0).at(index)[i] - ((double)*currentFeaturesC_Pt.at(0)))) which means abs(a*a), a is short for the ((double)B_Col_Pts.at(0).at(index)[i] - ((double)*currentFeaturesC_Pt.at(0)) distance

@andrewssobral
Copy link
Owner

Hi @batman47steam,
Thank you for bringing this issue to our attention.

@andrewssobral andrewssobral self-assigned this Feb 25, 2023
andrewssobral added a commit that referenced this issue Feb 25, 2023
@andrewssobral
Copy link
Owner

Issue fixed 0b2462b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants