Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace division with non-deprecated syntax #221

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Replace division with non-deprecated syntax #221

merged 2 commits into from
Nov 21, 2023

Conversation

nogweii
Copy link
Contributor

@nogweii nogweii commented Nov 20, 2023

This fixes a warning about Dart Sass 2.0.0 removing support for literal division using just the / symbol.

Closes #220.

This fixes a warning about Dart Sass 2.0.0 removing support for literal
division using just the `/` symbol.

Closes #220.
@nogweii
Copy link
Contributor Author

nogweii commented Nov 20, 2023

This isn't necessary for v4 as you've avoided using division entirely there. It'd be nice to have a minor version bump including this change, but in the mean time others can include this fix in their package.json like so:

{
  "dependencies": {
    "keyrune": "git+https://github.com/nogweii/keyrune.git#5737f2466f4af4a9bf383c06385cee5304ae7a98"
  }
}

@andrewgioia andrewgioia merged commit ba78665 into andrewgioia:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart Sass is deprecating division syntax outside of calc
2 participants