Adds comments to address notes

andrewfullard · May 23, 2024 · f39ce98 · f39ce98
1 parent fa82703
commit f39ce98
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/benchmarks/transport_montecarlo_numba_formal_integral_p.py b/benchmarks/transport_montecarlo_numba_formal_integral_p.py
@@ -77,6 +77,8 @@ def formal_integral_geometry(self, r):
 
     @property
     def time_explosion(self):
+        # previously used model value that passes tests
+        # time taken for a photon to move 1 cm
         return 1 / c.c.cgs.value
 
     @parameterize({"p": [0.0, 0.5, 1.0], "Test data": TESTDATA})

diff --git a/tardis/transport/montecarlo/montecarlo_main_loop.py b/tardis/transport/montecarlo/montecarlo_main_loop.py
@@ -47,6 +47,7 @@ def montecarlo_main_loop(
     geometry_state : GeometryState
         Simulation geometry
     time_explosion : float
+        Time in seconds
     opacity_state : OpacityState
     estimators : Estimators
     spectrum_frequency :  astropy.units.Quantity

diff --git a/tardis/transport/montecarlo/tests/test_cuda_formal_integral.py b/tardis/transport/montecarlo/tests/test_cuda_formal_integral.py
@@ -123,6 +123,8 @@ def time_explosion():
     """
     This gets the time_explosion to be used in later tests
     """
+    # previously used model value that passes tests
+        # time taken for a photon to move 1 cm
     return 1 / c.c.cgs.value