Fixes logic to detect when a thing's config changes vs the whole thin…

…g structure (openhab#2729) Fixes openhab#2704 --------- Signed-off-by: Dan Cunningham <[email protected]>
andrewfg · Aug 25, 2024 · 77dbfcb · 77dbfcb
1 parent 6139039
commit 77dbfcb
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue
@@ -350,11 +350,17 @@ export default {
           // create rule object clone in order to be able to delete status part
           // which can change from eventsource but doesn't mean a rule modification
           let thingClone = cloneDeep(this.thing)
-          delete thingClone.statusInfo
-          delete this.savedThing.statusInfo
+          let savedThingClone = cloneDeep(this.savedThing)
+
+          // check if the configuration has changed between the thing and the original/saved version
+          this.configDirty = !fastDeepEqual(thingClone.configuration, savedThingClone.configuration)
 
-          this.configDirty = !fastDeepEqual(thingClone.configuration, this.savedThing.configuration)
-          this.thingDirty = !fastDeepEqual(thingClone, this.savedThing)
+          // check if the rest of the thing has changed between the thing and the original/saved version
+          delete thingClone.statusInfo
+          delete thingClone.configuration
+          delete savedThingClone.statusInfo
+          delete savedThingClone.configuration
+          this.thingDirty = !fastDeepEqual(thingClone, savedThingClone)
         }
       },
       deep: true