-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private file uploads and remove date folder requirement #9
base: master
Are you sure you want to change the base?
Conversation
This should be added into a config file.
I needed to be able to sometimes upload to a "private" (not in public folder) folder.
@andrewelkins what do you think about these changes? |
As I look more and more at this package... I have a question.. Why specify 2 paths:
Shouldn't this be simplified and use one path? |
On upload vs public path. They are used in different spots. the folder is the pull path, whereas the public path is off of the web root. |
Why did you remove the date folder path? |
It seemed odd to hard code it. |
The date folder path prevents making a single folder gigantic. Years ago it was done this way to prevent exhausting the file count limit within a folder. Now it just prevents a folder becoming so huge that it's nearly impossible to do anything useful in. eg. ls taking minutes or doing a grep/find |
@andrewelkins |
Thanks @olso |
Couldn't this be added into a config file, possibly in upload_folder_public_path?
I don't think it should be hard coded.