remove interface argument to Dev.read() call #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface argument was removed at some point and is apparently unneeded. I also specified the timeout argument by name, so this will still work with older versions of pyusb that still have the interface parameter.
andrewdodd
added a commit
that referenced
this pull request
Dec 16, 2014
Accepting Jonathon's change. The change removes the unneeded "0" argument to the dev.read() call while maintaining backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1.
The
interfaceargument was removed at some point and is apparently unneeded.I also specified the
timeoutargument by name, so this will still work with older versions of pyusb that still have theinterfaceparameter.I tested this against the latest pyusb on Linux, and the version of pyusb I had installed on windows, which still has the
read(self, endpoint, size, interface=None, timeout=None)signature.