fix(action): fixed abort message typo

andrewcourtice · Feb 17, 2022 · e49d77e · e49d77e
1 parent 82b1b7c
commit e49d77e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/extensions/action/src/errors.ts b/extensions/action/src/errors.ts
@@ -1,10 +1,14 @@
+import {
+    getAbortMessage,
+} from './utilities';
+
 export class ActionAbortError extends Error {
     public name: string;
     public instanceId: symbol;
     public reason?: unknown;
 
-    constructor(name: string, instanceId: symbol, reason: unknown = 'unknown') {
-        super(`Action ${name} as been cancelled. Reason: ${reason}`);
+    constructor(name: string, instanceId: symbol, reason?: unknown) {
+        super(getAbortMessage(name, reason));
 
         this.name = name;
         this.instanceId = instanceId;

diff --git a/extensions/action/src/index.ts b/extensions/action/src/index.ts
@@ -21,6 +21,10 @@ import {
     ActionAbortError,
 } from './errors';
 
+import {
+    getAbortMessage,
+} from './utilities';
+
 import type {
     Action,
     ActionAbortStrategies,
@@ -44,7 +48,7 @@ export const ABORT_STRATEGY = {
         reject(new ActionAbortError(name, id, reason));
     },
     warn: (name, id, resolve, reject, reason) => {
-        console.warn(`Action ${name} has been cancelled. Reason: ${reason || 'unknown'}`);
+        console.warn(getAbortMessage(name, reason));
         resolve();
     },
 } as ActionAbortStrategies;

diff --git a/extensions/action/src/utilities.ts b/extensions/action/src/utilities.ts
@@ -0,0 +1,3 @@
+export function getAbortMessage(name: string, reason: unknown) {
+    return `Action ${name} has been cancelled. Reason: ${reason || 'unknown'}`;
+}