fix(utilities): fixed overwrite ignore logic

andrewcourtice · Sep 6, 2021 · c1e4b49 · c1e4b49
1 parent 633076b
commit c1e4b49
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/utilities/src/object/overwrite.ts b/packages/utilities/src/object/overwrite.ts
@@ -4,9 +4,12 @@ export default function overwrite<TTarget extends object, TSource extends object
     }
 
     for (const prop in target) {
-        if (!ignorePattern || !ignorePattern.test(prop)) {
-            delete target[prop];
+        if (ignorePattern && ignorePattern.test(prop)) {
+            delete (source as Record<string, unknown>)[prop];
+            continue;
         }
+
+        delete target[prop];
     }
 
     return Object.assign(target, source);

diff --git a/packages/utilities/test/overwrite.test.ts b/packages/utilities/test/overwrite.test.ts
@@ -41,6 +41,7 @@ describe('Utilities', () => {
                 a: 'hello',
                 b: 5,
                 c: [1, 2],
+                d: 35,
             }, /^d/);
 
             expect(typeof source.a).toBe('string');