refactor(trace): change node field names

andrewcourtice · Aug 5, 2021 · bdfef62 · bdfef62
1 parent 2d9cbda
commit bdfef62
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/extensions/trace/src/index.ts b/extensions/trace/src/index.ts
@@ -8,6 +8,7 @@ import {
     clone,
     isArray,
     isObject,
+    toPath,
 } from '@harlem/utilities';
 
 import type {
@@ -51,16 +52,22 @@ function defaultCallback<TValue extends object>(
     callback: TraceCallback<TValue>,
     gate: TraceGate<TValue>,
     paths: PropertyKey[],
-    key: PropertyKey,
+    prop: PropertyKey,
     oldValue: unknown,
     newValue?: unknown,
 ) {
     try {
+        const nodes = paths.slice();
+
         callback({
             gate,
+            nodes,
+            prop,
             newValue,
-            paths: paths.concat(key),
             oldValue: newValue === oldValue ? oldValue : clone(oldValue),
+            get path() {
+                return toPath(nodes.concat(prop));
+            },
         });
     } catch {
         console.warn('Trace callback failed');

diff --git a/extensions/trace/src/types.ts b/extensions/trace/src/types.ts
@@ -12,8 +12,10 @@ export interface TraceOptions<TValue extends object> {
 }
 
 export interface TraceResult<TValue extends object> {
+    readonly path: string;
     gate: TraceGate<TValue>;
-    paths: PropertyKey[];
+    nodes: PropertyKey[];
+    prop: PropertyKey;
     oldValue: unknown;
     newValue: unknown;
 }