set_global_var() should not pass NULL pointers to dlclose()

Both Coverity and Clang's static analyzer caught this. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Richard Yao <[email protected]> Closes openzfs#14044
andrewc12 · Nov 9, 2022 · 023b3d4 · 023b3d4
1 parent 84aa84c
commit 023b3d4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/libzpool/util.c b/lib/libzpool/util.c
@@ -230,13 +230,14 @@ set_global_var(char const *arg)
 		fprintf(stderr, "Failed to open libzpool.so to set global "
 		    "variable\n");
 		ret = EIO;
-		goto out_dlclose;
+		goto out_free;
 	}
 
 	ret = 0;
 
 out_dlclose:
 	dlclose(zpoolhdl);
+out_free:
 	free(varname);
 out_ret:
 #endif