Fix race condition on first task attempt in update #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When first attempting a task in `update` (but not in `init`) the sub tasks were not run. The reason for this is because the model was not updated in time for the identify message. Adding Promise.resolve around the send command allows a tick to happen so elm can update the model in time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases where a task was first started in
update, the sub-tasks would not be run. This was because the Elm model was not updated in time before the firstpoolIdwas received.Adding a
Promise.resolvewrapper around thesend({ poolId })gives elm enough time to tick the model forward.