Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdo mysql strict mode - installa with languages enabled + content #67

Closed
wants to merge 1 commit into from

Conversation

alikon
Copy link

@alikon alikon commented Aug 26, 2016

Pull Request for Issue joomla#11763 .

fix for joomla#11763 pdo mysql strict mode - install with languages enabled + content

please test and do the same fix on mssql and when update

fix for  joomla#11763 pdo mysql strict mode - install with languages enabled + content
@andrepereiradasilva
Copy link
Owner

i already made a change in the PR yesterday, did you check the code diff. did you test the latest version.
Also i don't agree in removing the not null, all the other databases have it.

@alikon
Copy link
Author

alikon commented Aug 26, 2016

i followed this path

//$this->connection->query("SET @@SESSION.sql_mode = '';");
$this->connection->query("SET @@SESSION.sql_mode = 'STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION';");

strictpdo

p.s.
PDO sould be considered as a different DB .... what is valid for other's DB is not valid with PDO

i've uploaded a "dirty" video on youtube https://youtu.be/BNXSUJqJVSs with a step by step of the process i've followed hope this may help more

@andrepereiradasilva
Copy link
Owner

andrepereiradasilva commented Aug 27, 2016

@alikon i just saw your video yet again and discovered you get the error BEFORE installating any language. Minute 7:25 to end of your video

You get the error afer clicking "installa languages" to go to the language select.

This is different from the error i solved: the error when you selected a language and press install.

@alikon
Copy link
Author

alikon commented Aug 30, 2016

see #72

@alikon alikon closed this Aug 30, 2016
@alikon alikon deleted the patch-78 branch August 30, 2016 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants