Html libraries performance improvements #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Code review and performance optimizations/improvements in the following clases:
More relevant notes:
Added detectBrowser - false in all HTMLHelper js scripts loading so there is not searchs for 4 files (8 in debug mode) for file for each all possible relative paths - that's a lot a lstat filesystem calls (particulary when open_basedir config is enabled - see https://bugs.php.net/bug.php?id=52312).
The css files still have detect browser by default, but this should be removed as default.
corrected a bug in HTMLHelper::extract key generation
HTMLHelper::includeRelativeFiles was not changed since needs more work
Testing Instructions
Mainly code review and navigate around the site/admin to check if everything is fine.
Documentation Changes Required
None.