improve menu render performance #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmayer
reviewed
Jun 29, 2017
| } | ||
| elseif ($values[$key] === null) | ||
|
|
There was a problem hiding this comment.
Just a typo:
"// If access filter is not set, use "
|
Nice optimizations. Looking good on code review. I hope I didn't miss anything. Another pair of eyes would be good. |
frankmayer
reviewed
Jun 29, 2017
| @@ -16,36 +16,38 @@ | |||
| $id = ' id="' . $tagId . '"'; | |||
| } | |||
|
|
|||
| $pathSize = count($path); | |||
There was a problem hiding this comment.
line 20, sorry did not mark correctly
There was a problem hiding this comment.
Maybe also calling $pathReserve (note 'reserve' instead of 'reverse') $pathFlipped or $pathFlip?
frankmayer
approved these changes
Jun 29, 2017
|
@frankmayer this is only in my repo i did not submited a PR to joomla yet 😄 |
|
:D ah yes, didn't notice that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Improves performance and memory usage of the menu render.
Testing Instructions
TODO
Performance improvements
Test scenario:
Before
After
Documentation Changes Required
None.