Always store OCaml representation as a struct #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rixed wrote:
To be honest, I just copied the struct from the incomplete emulation side, although it did mean in an earlier version of what's now in #50 I accidentally had one of the 128-bit copies big endian and one little endian which was, um, amusing 🤦♂️ |
|
@rixed awaiting your review. |
|
a CHANGES entry would be welcome as well. |
This looks good to me! |
Pointers to 128-bit numbers must be 16-byte aligned which OCaml cannot guarantee. Always store the number in a struct and read it into a 128-bit integer.
rgrinberg
force-pushed
the
unaligned-128
branch
from
f49d158 to
cc56911
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Oct 28, 2020
CHANGES: ## Fixes: * Correct conversion from uint24 to other ints (andrenth/ocaml-stdint#39, @rixed) * Fix conversion from all ints to uint24 and int24 (andrenth/ocaml-stdint#41, @rixed) * Fix int24 failing to recover from casts (andrenth/ocaml-stdint#43, @rixed) * Fix sign extensions (andrenth/ocaml-stdint#49, @rixed) * `Long_val` returns `intnat`, previously `long` was used (andrenth/ocaml-stdint#53, @dra27) * Reduce size of marshalled custom values on 4.08+ (andrenth/ocaml-stdint#54, @dra27) * Store 128-bit ints as structs to prevent unaligned access (andrenth/ocaml-stdint#55, @dra27) ## New features: * Add `of_substring` (andrenth/ocaml-stdint#49, @darlentar)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Oct 28, 2020
CHANGES: ## Fixes: * Correct conversion from uint24 to other ints (andrenth/ocaml-stdint#39, @rixed) * Fix conversion from all ints to uint24 and int24 (andrenth/ocaml-stdint#41, @rixed) * Fix int24 failing to recover from casts (andrenth/ocaml-stdint#43, @rixed) * Fix sign extensions (andrenth/ocaml-stdint#49, @rixed) * `Long_val` returns `intnat`, previously `long` was used (andrenth/ocaml-stdint#53, @dra27) * Reduce size of marshalled custom values on 4.08+ (andrenth/ocaml-stdint#54, @dra27) * Store 128-bit ints as structs to prevent unaligned access (andrenth/ocaml-stdint#55, @dra27) ## New features: * Add `of_substring` (andrenth/ocaml-stdint#49, @darlentar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off from #50 and will shortly be an alternative to it. This version always stores the number as a struct and reads it into a 128-bit integer.