Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript minor fixes to enable backward compatibility to iPad2 #208

Closed
wants to merge 2 commits into from
Closed

Javascript minor fixes to enable backward compatibility to iPad2 #208

wants to merge 2 commits into from

Conversation

jacques42
Copy link
Contributor

In reference to issue "Backward compatibility: iPad2 / iOS 9.3.5" #207

@andi34
Copy link
Collaborator

andi34 commented Dec 11, 2019

Thanks for your contribution.
Using latest webkit nightly should solve the issue, source: https://webkit.org/blog/4054/es6-in-webkit/

@sualko
Copy link
Collaborator

sualko commented Dec 11, 2019

Going back to es5 is no option in my opinion. Use a transpiler or install some kind of modern browser to your device. We can't support every legacy device and it would prohibit further development.

@andi34 andi34 added the wontfix label Dec 11, 2019
@jacques42
Copy link
Contributor Author

That's ok and I'm not asking for to implement backward compatibility. I was looking for a use-case of old equipement (iPad2) to be able to reuse instead of just dump and buy new.

Thanks for the product and thanks for the effort to build and maintain, I really appreciate all your work. Let me close this conversation here, thanks for taking the time to go through it.

@jacques42 jacques42 closed this Dec 11, 2019
@Sockenfisch
Copy link

I also want to use my iPad2 for the photo box. Unfortunately I don't understand how and where I have to change something. Could you please give instructions on which commands to use to change what and where.
Which directory, which file ... ?

Thanks a lot!

@andi34
Copy link
Collaborator

andi34 commented Jun 20, 2020

@Sockenfisch you can use the package provided here if you like andi34#47

@jacques42
Copy link
Contributor Author

@andi34 thanks for maintaining this package 👍

@Sockenfisch
Copy link

Sockenfisch commented Jul 13, 2020 via email

@andi34
Copy link
Collaborator

andi34 commented Jul 13, 2020

Hättest gerne auch da fragen können.
Dein "Origin" (remote) liegt wahrscheinlich hier auf dem Repo. Kannst du mit git remote -v nachschauen.
Aber geht ganz einfach:

cd /var/www/html
sudo -u www-data -s
git remote add andi34 https://github.com/andi34/photobooth
git fetch andi34
git checkout andi34/ipad2
git submodule update --init
yarn install
yarn build
exit

Die v2.6.0 wäre über

git checkout andi34/stable2

verfügbar. Die restlichen git - Befehle wie gehabt.

@Sockenfisch
Copy link

Sockenfisch commented Jul 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants