Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install error on windows #207

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

Allisson95
Copy link

Fix #195

Copy link

@Herna1994 Herna1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this with your source

PS C:\Users\herna\Desktop\Desarrollo\delegacionDeportes> ionic cordova plugin add cordova-plugin-fcm-with-dependecy-updated

cordova.cmd plugin add cordova-plugin-fcm-with-dependecy-updated
Installing "cordova-plugin-fcm-with-dependecy-updated" for android
Subproject Path: CordovaLib
Subproject Path: app
Running hook: C:\Users\herna\Desktop\Desarrollo\delegacionDeportes\plugins\cordova-plugin-fcm-with-dependecy-updated\scripts\install_ionic_dependencies.bat C:\Users\herna\Desktop\Desarrollo\delegacionDeportes
El sistema no puede encontrar la ruta especificada.
El sistema no puede encontrar la ruta especificada.
internal/modules/cjs/loader.js:883
throw err;
^

Error: Cannot find module 'C:\Users\herna\Desktop\Desarrollo\delegacionDeportes\node_modules\install_ionic_dependencies.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
internal/modules/cjs/loader.js:883
throw err;
^

Error: Cannot find module 'C:\Users\herna\Desktop\Desarrollo\delegacionDeportes\node_modules\install_ionic_dependencies.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
internal/modules/cjs/loader.js:883
throw err;
^

Error: Cannot find module 'C:\Users\herna\Desktop\Desarrollo\delegacionDeportes\node_modules\install_ionic_dependencies.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Failed to install 'cordova-plugin-fcm-with-dependecy-updated': Error: Command failed with exit code 1: C:\Users\herna\Desktop\Desarrollo\delegacionDeportes\plugins\cordova-plugin-fcm-with-dependecy-updated\scripts\install_ionic_dependencies.bat C:\Users\herna\Desktop\Desarrollo\delegacionDeportes
at makeError (C:\Users\herna\AppData\Roaming\npm\node_modules\cordova\node_modules\execa\lib\error.js:59:11)
at handlePromise (C:\Users\herna\AppData\Roaming\npm\node_modules\cordova\node_modules\execa\index.js:114:26)
Command failed with exit code 1: C:\Users\herna\Desktop\Desarrollo\delegacionDeportes\plugins\cordova-plugin-fcm-with-dependecy-updated\scripts\install_ionic_dependencies.bat C:\Users\herna\Desktop\Desarrollo\delegacionDeportes
at processTicksAndRejections (internal/process/task_queues.js:93:5)
[ERROR] An error occurred while running subprocess cordova.

    cordova.cmd plugin add cordova-plugin-fcm-with-dependecy-updated exited with exit code 1.

    Re-running this command with the --verbose flag may provide more information.

@Allisson95
Copy link
Author

Hi @Herna1994

I think it might be something with the local installation.
I have successfully tested it on Windows and macOS machines.

A piece of package.json:

{
  ...
  "devDependencies": {
    ...
    "cordova": "^10.0.0",
    "cordova-android": "^9.0.0",
    "cordova-ios": "^6.1.1",
    "cordova-plugin-fcm-with-dependecy-updated": "git+https://github.com/Allisson95/cordova-plugin-fcm-with-dependecy-updated.git",
    ...
  },
  "cordova": {
    "plugins": {
      ...
      "cordova-plugin-fcm-with-dependecy-updated": {
        "ANDROID_DEFAULT_NOTIFICATION_ICON": "@mipmap/ic_launcher",
        "ANDROID_FCM_VERSION": "21.0.0",
        "ANDROID_FIREBASE_BOM_VERSION": "26.0.0",
        "ANDROID_GOOGLE_SERVICES_VERSION": "4.3.4",
        "ANDROID_GRADLE_TOOLS_VERSION": "4.1.0"
      }
    },
    "platforms": [
      "android",
      "ios"
    ]
  }
}

Copy link
Owner

@andrehtissot andrehtissot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I'll finish tests and have it released

@andrehtissot andrehtissot merged commit 394864c into andrehtissot:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to install Error: Command failed with exit code 1
3 participants