Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return instance version from server info if available #290

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

PattaFeuFeu
Copy link
Collaborator

Description

#270 accidentally added a change where the instance version was no longer returned even if we got one from the NodeInfoClient, so we always fell back to getting the instance info through the Mastodon API.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Dependency update / replacement

How Has This Been Tested?

gradle check

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation if necessary
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #290 (39ceeb9) into master (d80d2e1) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
- Coverage     35.89%   35.88%   -0.02%     
  Complexity      348      348              
============================================
  Files           101      101              
  Lines          3034     3035       +1     
  Branches        183      184       +1     
============================================
  Hits           1089     1089              
- Misses         1825     1826       +1     
  Partials        120      120              
Files Coverage Δ
...e/src/main/kotlin/social/bigbone/MastodonClient.kt 32.11% <50.00%> (-0.12%) ⬇️

Copy link
Collaborator

@bocops bocops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocops bocops merged commit 2fa6004 into andregasser:master Oct 16, 2023
@PattaFeuFeu PattaFeuFeu deleted the return-node-info-if-available branch October 16, 2023 08:18
@andregasser
Copy link
Owner

Thanks for the review @bocops 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants