-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement endorsements API #286
Merged
andregasser
merged 10 commits into
andregasser:master
from
PattaFeuFeu:261/endorsements_api
Oct 21, 2023
Merged
Implement endorsements API #286
andregasser
merged 10 commits into
andregasser:master
from
PattaFeuFeu:261/endorsements_api
Oct 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
============================================
+ Coverage 35.74% 36.33% +0.59%
- Complexity 348 362 +14
============================================
Files 101 103 +2
Lines 3047 3069 +22
Branches 184 184
============================================
+ Hits 1089 1115 +26
+ Misses 1838 1833 -5
- Partials 120 121 +1
|
# Conflicts: # bigbone-rx/src/test/kotlin/social/bigbone/rx/testtool/MockClient.kt
PattaFeuFeu
commented
Oct 15, 2023
andregasser
previously approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
andregasser
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the current state of the Endorsements API so that consumers of this library can get
Accounts
s that the user is currently featuring on their profile.I have changed
MockClient
to be a wee bit more versatile and malleable when called from tests.Closes #261.
Type of Change
https://github.com/andregasser/bigbone/wiki/Mastodon-API-Coverage#methods needs to be updated after this has been merged!
How Has This Been Tested?
gradle check
Checklist