Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled bit code for both build and archive #9

Merged
merged 1 commit into from
Mar 14, 2016

Conversation

nyxhub
Copy link
Contributor

@nyxhub nyxhub commented Mar 14, 2016

Enabled bit code for both build and archive. As a side effect this makes the library support bit code enabled projects that use Carthage

For reference follow Carthage/Carthage#535

if BITCODE_GENERATION_MODE is not set to bitcode, projects using carthage will not be able to submit apps to appstore (or just archive them) even when enable bitcode setting is set to yes. Explanation in the link above.

The library is used in www.monogram.me

…kes the library support bit code enabled projects that use Carthage
@andreamazz
Copy link
Owner

Hi @gabrielnica, thanks for the heads up, I'll make sure to enable it on all the other libs.
Great to hear that this control is used in your app 👍

andreamazz added a commit that referenced this pull request Mar 14, 2016
Enabled bit code for both build and archive
@andreamazz andreamazz merged commit 3a8d844 into andreamazz:master Mar 14, 2016
@nyxhub
Copy link
Contributor Author

nyxhub commented Mar 14, 2016

You're welcome, thank you too for creating the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants