Context menu follow up #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 11, 2021 15:26
- Swapped actual examples between Sizes and Single panel - Added some more to a few snippets
- Also updated the euiPopoverTitle mixin to accept a size prop and re-created it for Amsterdam for better adjustments.
|
@andreadelrio Not sure if you saw this one, I know notifications on forks can be iffy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up some examples:
Created a specific small title class instead of relying on nesting …
euiPopoverTitle()mixin to accept a size prop and re-created it for Amsterdam for better adjustments. This required less actual override structures.Added prop comments and a few more tests.