Skip to content

Commit

Permalink
[EuiPopover] Fix popover returning focus to correct element (elastic#…
Browse files Browse the repository at this point in the history
…4071)

* Move onclickoutside / onescape handling to focus-lock lib itself

* Get popover focus return functioning

* Fix lint issues & snapshots, re-enable clickOutsideDisables prop for EuiFocusTrap

* fix popover re-toggling when clicking its anchor

* Re-enable popover outside click and escape key detection when ownFocus is false

* Only call popover's closePopover callback when it is open

* Don't scroll back to a popover anchor when the popover closes

* Address unintentional changes to flyouts & color picker

* changelog

* revert changes to popover example, which had been made to augment testing

* Fix flyout's snapshot tests
  • Loading branch information
chandlerprall authored and cchaos committed Nov 4, 2020
1 parent 17d6823 commit 7c33a37
Show file tree
Hide file tree
Showing 13 changed files with 1,132 additions and 1,187 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

**Bug fixes**

- Fixed focus trap + `EuiPopover` bug which prevented the anchor from receiving focus when the popover closes ([#4071](https://github.com/elastic/eui/pull/4071))
- Fixed focus trap error & performance impact when one focus trap is deactivated and another becomes enabled ([#4071](https://github.com/elastic/eui/pull/4071))
- Fixed a condition in `EuiInMemoryTable` to avoid mistaken assignment of `sortName` ([#4138](https://github.com/elastic/eui/pull/4138))

## [`30.2.0`](https://github.com/elastic/eui/tree/v30.2.0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
panelPaddingSize="none"
>
<EuiOutsideClickDetector
isDisabled={true}
onOutsideClick={[Function]}
>
<div
Expand Down
Loading

0 comments on commit 7c33a37

Please sign in to comment.