Define parameters as let if no parameters

andooown · Oct 21, 2023 · 9a36c33 · 9a36c33
1 parent 4d50233
commit 9a36c33
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 10 deletions.
diff --git a/Sources/LexiconGenKit/Generator/Generator+Builders.swift b/Sources/LexiconGenKit/Generator/Generator+Builders.swift
@@ -94,16 +94,24 @@ public extension Generator {
                                 return "parameters.append(contentsOf: \(k).toQueryItems(name: \"\(k)\"))"
                             }
 
-                        try VariableDeclSyntax(
-                            """
-                            public var queryItems: [URLQueryItem] {
-                                var parameters = [URLQueryItem]()
-                                \(raw: params.joined(separator: "\n"))
-
-                                return parameters
-                            }
-                            """
-                        )
+                        if params.isEmpty {
+                            try VariableDeclSyntax(
+                                """
+                                public let queryItems: [URLQueryItem] = []
+                                """
+                            )
+                        } else {
+                            try VariableDeclSyntax(
+                                """
+                                public var queryItems: [URLQueryItem] {
+                                    var parameters = [URLQueryItem]()
+                                    \(raw: params.joined(separator: "\n"))
+
+                                    return parameters
+                                }
+                                """
+                            )
+                        }
                     }
                 }
 

diff --git a/Tests/LexiconGenKitTests/Generator/Generator+BuildersTests.swift b/Tests/LexiconGenKitTests/Generator/Generator+BuildersTests.swift
@@ -234,6 +234,46 @@ final class GeneratorBuildersTests: XCTestCase {
         )
 
         // query
+        XCTAssertNoDifference(
+            try Generator.definition(
+                makeDefinition(
+                    .query(
+                        LexiconMethodSchema(
+                            parameters: LexiconObjectSchema(properties: [:], required: nil),
+                            input: nil,
+                            output: .object(LexiconObjectSchema(properties: [:], required: nil))
+                        )
+                    )
+                )
+            ).formatted().description,
+            """
+            struct Foo: XRPCRequest {
+                public struct Parameters: XRPCRequestParametersConvertible {
+                    public init(
+
+                    ) {
+
+                    }
+                    public let queryItems: [URLQueryItem] = []
+                }
+                public struct Output: Decodable, Hashable {
+                    public init(
+
+                    ) {
+
+                    }
+                }
+                public init(
+                    parameters: Parameters
+                ) {
+                    self.parameters = parameters
+                }
+                public let type = XRPCRequestType.query
+                public let requestIdentifier = "com.example.foo"
+                public let parameters: Parameters
+            }
+            """
+        )
         XCTAssertNoDifference(
             try Generator.definition(
                 makeDefinition(