Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/anm gbfs version #41

Merged
merged 4 commits into from
Dec 29, 2019
Merged

Feature/anm gbfs version #41

merged 4 commits into from
Dec 29, 2019

Conversation

andmos
Copy link
Owner

@andmos andmos commented Dec 28, 2019

Fixes #40

For #40, use versining in DTO's.
Default to version `1.0` if version field is null or can't be parsed.
@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@66f6620). Click here to learn what that means.
The diff coverage is 79.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   90.85%           
=========================================
  Files             ?       18           
  Lines             ?      317           
  Branches          ?        0           
=========================================
  Hits              ?      288           
  Misses            ?       29           
  Partials          ?        0
Impacted Files Coverage Δ
...keshareClient/BikeshareClient/Models/BikeStatus.cs 100% <100%> (ø)
src/BikeshareClient/BikeshareClient/DTO/GbfsDTO.cs 85.71% <100%> (ø)
.../BikeshareClient/BikeshareClient/Models/Station.cs 100% <100%> (ø)
src/BikeshareClient/BikeshareClient/Models/Feed.cs 100% <100%> (ø)
...Client/BikeshareClient/Models/SystemInformation.cs 95.83% <100%> (ø)
...hareClient/BikeshareClient/Models/StationStatus.cs 96.66% <100%> (ø)
...keshareClient/BikeshareClient/DTO/BikeStatusDTO.cs 78.57% <40%> (ø)
...Client/Helpers/StringToSemanticVersionConverter.cs 44.44% <44.44%> (ø)
.../BikeshareClient/BikeshareClient/DTO/StationDTO.cs 92.85% <50%> (ø)
...Client/BikeshareClient/DTO/SystemInformationDTO.cs 70% <66.66%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f6620...092f6ae. Read the comment docs.

@andmos andmos merged commit 4f8b002 into master Dec 29, 2019
@andmos andmos deleted the feature/anm-GBFSVersion branch December 29, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement versioning field
1 participant